Run process_builder_pending_payments before effective balance updates
#4737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
changed the title
process_builder_pending_payments before effective balance updates
jtraglia
approved these changes
Nov 14, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Thanks @shane-moore, this change makes sense to me. We discussed this on the last ePBS breakout call and there was no real arguments against making this change. I believe potuz stated that he just added the call to the end of the function without much thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long form reasoning on this change in the discord chat
TLDR:
Move
process_builder_pending_paymentsto run beforeprocess_effective_balance_updatesinprocess_epoch. This makescompute_exit_epoch_and_update_churnuse the current epoch effective balances, matchingprocess_execution_payloadbehavior and avoiding inconsistent updates tostate.exit_balance_to_consumeandstate.earliest_exit_epoch